fix: undefined variable enrollment action in new enrollment request #60
Conversation
openedx-webhooks
added
the
open-source-contribution
|
Thanks for the pull request, @julianramirez2! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
MaferMazu
force-pushed
the
undefined-enrollment-action
branch
from
5e99614 to
b6cdd83
Compare
There was a problem hiding this comment.
Thanks for this PR @julianramirez2, this fixes the warning creating a new enrollment.
Screenshot of the bug
Screenshot with this fix
|
@julianramirez2 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
Description
This small adjustment in the code makes an error that only appeared in a Local execution of the code disappear. Before, when creating a new Enrollment Request manually, a message appeared at the top of the form saying that the Enrollment Action variable was not defined this happened because, in fact, in a new post, there was no enrollment action and we were not checking whether this action was set or not to assign it to an empty variable.
Testing instructions
Run the project locally and create a new Enrollment Request.
Checklist for Merge